Commits on Nov 4, 2022

1. helper/resource: Various small fixes …

   Reference: #1063
   Reference: hashicorp/go-plugin#220
   
   This includes the following small bug fixes:
   
   - Clarifies/fixes the trace logging during `terraform show` commands
   - Improves performance slightly for `terraform show` raw plan usage (terraform-exec already captures and returns stdout for raw plans)
   - Prevents a goroutine leak specific to the detached stop context in `schema.GRPCProvider`
   
   Previously, leak detection on testing would contain an entry per Terraform command such as:
   
   ```
           [Goroutine 276 in state select, with github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.mergeStop on top of the stack:
           goroutine 276 [select]:
           github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.mergeStop({0x103a5f298?, 0x14000390c00?}, 0x1400033e5f0, 0x140004bb560)
                   /Users/bflad/src/github.com/hashicorp/terraform-plugin-sdk/helper/schema/grpc_provider.go:46 +0x64
           created by github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).StopContext
                   /Users/bflad/src/github.com/hashicorp/terraform-plugin-sdk/helper/schema/grpc_provider.go:63 +0x178
           ]
   ```
   
   Leaked goroutines such as:
   
   ```
           [Goroutine 53 in state select, with github.com/hashicorp/go-plugin.(*gRPCBrokerServer).Recv on top of the stack:
           goroutine 53 [select]:
           github.com/hashicorp/go-plugin.(*gRPCBrokerServer).Recv(0x29?)
                   /Users/bflad/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.4/grpc_broker.go:121 +0x58
           github.com/hashicorp/go-plugin.(*GRPCBroker).Run(0x140003ca190)
                   /Users/bflad/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.4/grpc_broker.go:411 +0x40
           created by github.com/hashicorp/go-plugin.(*GRPCServer).Init
                   /Users/bflad/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.4/grpc_server.go:85 +0x424
           ]
   ```
   
   Will likely require a fix upstream in go-plugin.

   

   bflad committed Nov 4, 2022
   Copy the full SHA

   e46f11f View commit details

   Browse the repository at this point in the history

2. Update CHANGELOG for #1091

   

   bflad committed Nov 4, 2022
   Copy the full SHA

   2e615bd View commit details

   Browse the repository at this point in the history