Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: fix unknown value validation bug #1047

Merged
merged 3 commits into from Sep 2, 2022

Commits on Sep 2, 2022

  1. schema: fix unknown value validation bug

    The validate function should exit early in the case that a value is not
    wholly known. This is the intent of the comment and earlier code in this
    file - however, subsequent refactors introduced a bug in which one
    aspect of validation was run for unknown values: deprecation warnings.
    
    Deprecation warnings for known values are generated by validateType
    lower down.
    
    This fix ensures that deprecation warnings are not shown for unknown
    values, while still ensuring we exit validation early for all unknown
    values.
    kmoe committed Sep 2, 2022
    Copy the full SHA
    0f64ef7 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    db2b35b View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    d7e1fd9 View commit details
    Browse the repository at this point in the history