Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tfsdklog: Ensure sink logger options are propagated to SDK and provider root loggers #58

Merged
merged 4 commits into from May 4, 2022
Merged

tfsdklog: Ensure sink logger options are propagated to SDK and provider root loggers #58

merged 4 commits into from May 4, 2022

Commits on May 3, 2022

  1. tfsdklog: Ensure sink logger options are propagated to SDK and provid… 

    …er root loggers

Reference: #54

Verified via terraform-provider-corner.

Previously:

```console
$ TF_ACC=1 TF_LOG=WARN go test -count=1 -run='TestAccFrameworkResourceUser$' -v ./internal/frameworkprovider
=== RUN   TestAccFrameworkResourceUser
2022-05-03T14:42:25.505-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:43.666-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:43.668-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:43.668-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:43.670-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:43.671-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:43.671-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:43.672-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:43.672-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:48.245-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:48.247-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:48.248-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:48.249-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:48.249-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:48.249-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:48.252-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:48.253-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:52.798-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:55.552-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:55.554-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:55.555-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:55.555-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:55.556-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:55.557-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:42:55.558-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:00.146-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:04.701-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:04.703-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:04.703-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:04.704-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:04.705-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:04.705-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:04.706-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:04.707-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:04.707-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:09.252-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:13.803-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:13.805-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:13.806-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:13.807-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:13.808-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:13.808-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:13.809-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:13.810-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:13.811-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:13.811-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:18.382-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:18.385-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:18.385-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:18.387-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:18.387-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:18.387-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:18.388-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:18.389-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:18.390-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:22.938-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:25.649-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:30.199-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:30.200-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:30.200-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:30.203-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:30.203-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:30.205-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:30.206-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:30.206-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:30.206-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
2022-05-03T14:43:30.207-0400 [WARN]  sdk: Unable to create logging subsystem with AdditionalLocationOffset due to missing root logger options
--- PASS: TestAccFrameworkResourceUser (64.75s)
PASS
ok      github.com/hashicorp/terraform-provider-corner/internal/frameworkprovider       65.006s
```

Now:

```console
$ TF_ACC=1 TF_LOG=WARN go test -count=1 -run='TestAccFrameworkResourceUser$' -v ./internal/frameworkprovider
=== RUN   TestAccFrameworkResourceUser
--- PASS: TestAccFrameworkResourceUser (64.76s)
PASS
ok      github.com/hashicorp/terraform-provider-corner/internal/frameworkprovider       68.569s
```
    @bflad
    bflad committed May 3, 2022
    Copy the full SHA
    0ceaff7 View commit details
    Browse the repository at this point in the history

  2. tfsdklog: Ensure Name is properly set with sink when creating new roo… 

    …t loggers
    @bflad
    bflad committed May 3, 2022
    Copy the full SHA
    686a284 View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG for #58

    @bflad
    bflad committed May 3, 2022
    Copy the full SHA
    615c32c View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. Merge branch 'main' into bflad-fix-warnings

    @bflad
    bflad committed May 4, 2022
    Copy the full SHA
    9b224a2 View commit details
    Browse the repository at this point in the history