Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding go toolchain directive #384

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Adding go toolchain directive #384

merged 3 commits into from
Mar 5, 2024

Conversation

bendbennett
Copy link
Contributor

@bendbennett bendbennett commented Feb 29, 2024 •
edited

Reference: https://github.com/hashicorp/terraform-providers-devex-internal/issues/175

  • Reinstating the go toolchain directive in go.mod.

@bendbennett bendbennett added the dependencies Pull requests that update a dependency file label Feb 29, 2024
@bendbennett bendbennett added this to the v0.22.1 milestone Feb 29, 2024
@bendbennett bendbennett requested a review from a team as a code owner February 29, 2024 14:36
austinvalle
austinvalle approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀 , ref: https://github.com/hashicorp/terraform-providers-devex-internal/issues/175

@bendbennett bendbennett merged commit 720b648 into main Mar 5, 2024
66 checks passed
@bendbennett bendbennett deleted the bendbennett/go-toolchain branch March 5, 2024 11:25
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@austinvalle austinvalle austinvalle approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v0.22.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bendbennett @austinvalle