Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarification for nil check of ProviderData in data source and resource Configure() method #951

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

bendbennett
Copy link
Contributor

Reference: https://github.com/hashicorp/tutorials/issues/1944

Updating documentation to clarify that a nil check of ProviderData should always be performed in the Configure() method of data sources and resources.

@bendbennett bendbennett added the documentation Improvements or additions to documentation label Mar 13, 2024
@bendbennett bendbennett added this to the v1.7.0 milestone Mar 13, 2024
@bendbennett bendbennett requested a review from a team as a code owner March 13, 2024 10:19
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent update 🚀

@bendbennett bendbennett merged commit d88ef0e into main Mar 13, 2024
4 checks passed
@bendbennett bendbennett deleted the bendbennett/docs-configure-nil-check branch March 13, 2024 12:49
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants