Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attr.Value → attr.Type #949

Merged
merged 2 commits into from
Mar 12, 2024
Merged

attr.Value → attr.Type #949

merged 2 commits into from
Mar 12, 2024

Conversation

skyzyx
Copy link
Contributor

@skyzyx skyzyx commented Mar 11, 2024

These should be types, according to the Golang LSP in my IDE.

@skyzyx skyzyx requested a review from a team as a code owner March 11, 2024 19:13
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 11, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

bendbennett
bendbennett approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skyzyx thank you for this fix.

@bflad bflad added the documentation Improvements or additions to documentation label Mar 12, 2024
@bflad bflad added this to the v1.7.0 milestone Mar 12, 2024
@bendbennett bendbennett merged commit b1b8ae4 into hashicorp:main Mar 12, 2024
3 checks passed
@austinvalle austinvalle mentioned this pull request Mar 12, 2024
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bendbennett bendbennett bendbennett approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skyzyx @hashicorp-cla @bendbennett @bflad