Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example errors in custom-types.mdx #756

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Fix example errors in custom-types.mdx #756

merged 1 commit into from
Jun 12, 2023

Conversation

bpg
Copy link
Contributor

@bpg bpg commented Jun 11, 2023 •
edited

Fix minor errors / typos in custom-types.mdx

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 11, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@bpg bpg changed the title Fix example errors ins custom-types.mdx Fix example errors in custom-types.mdx Jun 11, 2023
@bpg bpg marked this pull request as ready for review June 11, 2023 18:59
@bpg bpg requested a review from a team as a code owner June 11, 2023 18:59
bflad
bflad approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for these fixes, @bpg 🚀 Looks good to me.

@bflad bflad added the documentation Improvements or additions to documentation label Jun 12, 2023
@bflad bflad added this to the v1.4.0 milestone Jun 12, 2023
@bflad bflad merged commit 76705ee into hashicorp:main Jun 12, 2023
5 checks passed
@bflad bflad modified the milestones: v1.4.0, v1.3.1 Jun 13, 2023
@bpg bpg deleted the patch-1 branch July 3, 2023 00:17
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bpg @hashicorp-cla @bflad