types/basetypes: Prevent panics in ListType, MapType, and SetType methods when ElemType field is not set
#755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e` methods when `ElemType` field is not set Reference: #714 Previously before logic updates: ``` --- FAIL: TestListTypeString (0.00s) --- FAIL: TestListTypeString/ElemType-missing (0.00s) panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x2 addr=0x28 pc=0x102ff0068] goroutine 19 [running]: testing.tRunner.func1.2({0x1030efe00, 0x1032e7b10}) /opt/homebrew/Cellar/go/1.20.5/libexec/src/testing/testing.go:1526 +0x1c8 testing.tRunner.func1() /opt/homebrew/Cellar/go/1.20.5/libexec/src/testing/testing.go:1529 +0x384 panic({0x1030efe00, 0x1032e7b10}) /opt/homebrew/Cellar/go/1.20.5/libexec/src/runtime/panic.go:884 +0x204 github.com/hashicorp/terraform-plugin-framework/types/basetypes.ListType.String(...) /Users/bflad/src/github.com/hashicorp/terraform-plugin-framework/types/basetypes/list_type.go:115 github.com/hashicorp/terraform-plugin-framework/types/basetypes.TestListTypeString.func1(0x14000082ea0) /Users/bflad/src/github.com/hashicorp/terraform-plugin-framework/types/basetypes/list_type_test.go:287 +0x48 testing.tRunner(0x14000082ea0, 0x1400009a6f0) /opt/homebrew/Cellar/go/1.20.5/libexec/src/testing/testing.go:1576 +0x10c created by testing.(*T).Run /opt/homebrew/Cellar/go/1.20.5/libexec/src/testing/testing.go:1629 +0x368 --- FAIL: TestListTypeTerraformType (0.00s) --- FAIL: TestListTypeTerraformType/ElemType-missing (0.00s) panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x2 addr=0x30 pc=0x104acdd8c] goroutine 38 [running]: testing.tRunner.func1.2({0x104bd45a0, 0x104dcbb10}) /opt/homebrew/Cellar/go/1.20.5/libexec/src/testing/testing.go:1526 +0x1c8 testing.tRunner.func1() /opt/homebrew/Cellar/go/1.20.5/libexec/src/testing/testing.go:1529 +0x384 panic({0x104bd45a0, 0x104dcbb10}) /opt/homebrew/Cellar/go/1.20.5/libexec/src/runtime/panic.go:884 +0x204 github.com/hashicorp/terraform-plugin-framework/types/basetypes.ListType.TerraformType(...) /Users/bflad/src/github.com/hashicorp/terraform-plugin-framework/types/basetypes/list_type.go:53 github.com/hashicorp/terraform-plugin-framework/types/basetypes.TestListTypeTerraformType.func1(0x14000103860) /Users/bflad/src/github.com/hashicorp/terraform-plugin-framework/types/basetypes/list_type_test.go:71 +0x5c testing.tRunner(0x14000103860, 0x1400011c9f0) /opt/homebrew/Cellar/go/1.20.5/libexec/src/testing/testing.go:1576 +0x10c created by testing.(*T).Run /opt/homebrew/Cellar/go/1.20.5/libexec/src/testing/testing.go:1629 +0x368 --- FAIL: TestListTypeValueFromTerraform (0.00s) --- FAIL: TestListTypeValueFromTerraform/missing-element-type (0.00s) panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x2 addr=0x30 pc=0x10515a414] goroutine 28 [running]: testing.tRunner.func1.2({0x1052785a0, 0x10546fb10}) /opt/homebrew/Cellar/go/1.20.5/libexec/src/testing/testing.go:1526 +0x1c8 testing.tRunner.func1() /opt/homebrew/Cellar/go/1.20.5/libexec/src/testing/testing.go:1529 +0x384 panic({0x1052785a0, 0x10546fb10}) /opt/homebrew/Cellar/go/1.20.5/libexec/src/runtime/panic.go:884 +0x204 github.com/hashicorp/terraform-plugin-framework/types/basetypes.ListType.ValueFromTerraform({{0x0?, 0x0?}}, {0x1052c5630, 0x140000a4018}, {{0x1052c70d0?, 0x140000a35c0?}, {0x1052599c0?, 0x140000b62b8?}}) /Users/bflad/src/github.com/hashicorp/terraform-plugin-framework/types/basetypes/list_type.go:61 +0x64 github.com/hashicorp/terraform-plugin-framework/types/basetypes.TestListTypeValueFromTerraform.func1(0x140001389c0) /Users/bflad/src/github.com/hashicorp/terraform-plugin-framework/types/basetypes/list_type_test.go:195 +0x60 testing.tRunner(0x140001389c0, 0x140000928a0) /opt/homebrew/Cellar/go/1.20.5/libexec/src/testing/testing.go:1576 +0x10c created by testing.(*T).Run /opt/homebrew/Cellar/go/1.20.5/libexec/src/testing/testing.go:1629 +0x368 ```
austinvalle
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Makes sense to me. Good stuff! 🚀
Do we need an issue tracking the long-term/major version change to ElemType that is mentioned in #714 ?
|
@austinvalle created #761 👍 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #714
Previously before logic updates: