Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COMPLIANCE] Add copywrite config, GH workflow and headers #745

Merged
merged 12 commits into from
Jun 2, 2023

Conversation

austinvalle
Copy link
Member

Closes #656

This PR introduces:

  • make generate command that will auto-generate all copyright headers for this repo (hooks into go generate)
  • GH workflow that will error if copyright headers aren't present
  • Addition to the CONTRIBUTING.md on how to run license autogenerating commands

@austinvalle austinvalle requested a review from a team as a code owner June 1, 2023 20:44
@bflad bflad added this to the v1.3.0 milestone Jun 1, 2023
@austinvalle austinvalle changed the title [COMPLIANCE] Add copywrite config and GH workflow [COMPLIANCE] Add copywrite config, GH workflow and headers Jun 1, 2023
go.mod Outdated Show resolved Hide resolved
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor addition to the workflow, but otherwise looks great 🚀

@@ -1,4 +1,7 @@
#!/usr/bin/env bash
# Copyright (c) HashiCorp, Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay to merge in since the digital team should be adding this to their management and we can flag it during review if the header is trying to be removed.

.github/workflows/compliance.yml Outdated Show resolved Hide resolved
austinvalle and others added 2 commits June 2, 2023 10:21
Co-authored-by: Brian Flad <bflad417@gmail.com>
@austinvalle austinvalle merged commit c5f89cd into main Jun 2, 2023
20 checks passed
@austinvalle austinvalle deleted the av/compliance branch June 2, 2023 14:33
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants