Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update types.mdx #547

Closed
wants to merge 2 commits into from
Closed

update types.mdx #547

wants to merge 2 commits into from

Conversation

vravind1
Copy link
Member

broken links which was case sensitive

broken links which was case sensitive
@vravind1 vravind1 requested a review from a team as a code owner November 18, 2022 21:37
@vravind1 vravind1 added the documentation Improvements or additions to documentation label Nov 18, 2022
@@ -384,7 +384,7 @@ Call one of the following to create a `types.Object`:

Set are unordered, unique collections of a single element type.

-> Use [SetNestedAttributes](/plugin/framework/schemas#SetNestedAttributes) for sets of objects that need additional schema information. Use [ListType and List](#listtype-and-list) for ordered collections.
-> Use [SetNestedAttributes](/plugin/framework/schemas#setnestedattributes) for sets of objects that need additional schema information. Use [ListType and List](#listtype-and-list) for ordered collections.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a SetNestedAttributes section in the schemas page?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I missed it. should we create one here? as there is a link in types page

Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad
Copy link
Member

bflad commented Dec 13, 2022

It looks like this page was moved with #554 so if this change is still necessary, let's create a new pull request and get it merged in. 😄

@bflad bflad closed this Dec 13, 2022
@bflad bflad deleted the vravind1-fw-types-docs branch December 13, 2022 19:15
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants