Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Allowing Usage of Custom Types for Nested Attributes #533

Closed
wants to merge 5 commits into from

Conversation

bendbennett
Copy link
Contributor

@bendbennett bendbennett commented Nov 10, 2022

Closes: #532

Following changes are included in this PR:

  • Introduction of a FrameworkValue interface.
  • Moving fwschema/attribute.go to types/attribute.go to avoid import cycles.
  • Moving fwschema/nested_attributes.go to types/nested_attributes.go to expose NestedAttributes interface for use in custom nested attribute types.

I am not convinced that attribute.go and nested_attributes.go should be in the types pkg.

@bendbennett bendbennett added the enhancement New feature or request label Nov 10, 2022
@bendbennett
Copy link
Contributor Author

Closed by #553, #558, #546

@bendbennett bendbennett deleted the bendbennett/issues-532 branch November 30, 2022 14:50
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider Allowing Usage of Custom Types for Nested Attributes
1 participant