Consider Allowing Usage of Custom Types for Structural Elements #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendbennett
commented
Oct 7, 2022
| object, ok := value.(types.Object) | ||
| // coerceObjectValue no longer coerces value to types.Object, but performs a type assertion to verify that value fills | ||
| // attr.ValueWithAttrs interface. | ||
| func coerceObjectValue(schemaPath path.Path, value attr.Value) (attr.Value, diag.Diagnostics) { |
There was a problem hiding this comment.
Function signature could be altered to return attr.ValueWithAttrs so that type assertions are not required elsewhere.
Function name should also change to something like coerceValueWithAttrs.
bendbennett
force-pushed
the
bendbennett/issues-508
branch
from
5b8a4b5
to
c77bb9e
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #508
So far (2022-10-07) this draft PR only addresses allowing optionally specifying the type on a block. Further changes will be required for equivalent functionality with nested attributes.