New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix framework setting nested blocks within nested lists to nil #480
Fix framework setting nested blocks within nested lists to nil #480
Conversation
Hi @liamcervante 👋 Thanks for submitting this fix. I think this is an appropriate code change that was missed in #468 so thank you for catching it. Would you like to finish up this pull request or leave it for us? In order to get this in, let's:
```release-note:bug
internal/fwserver: Ensured nested block plan modifiers correctly set their request `AttributeConfig`, `AttributePlan`, and `AttributeState` values
```
Thanks again. |
I will work on this today! |
Ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much, @liamcervante 🚀
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes issue raised in #479 (comment)
Apologies, not sure of the process for raising PRs but this seemed very simple so I thought I'd give it a go. Feel free to close this if this needs to be tracked in a different way.