Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix framework setting nested blocks within nested lists to nil #480

Merged
merged 5 commits into from Sep 14, 2022

Conversation

liamcervante
Copy link
Member

@liamcervante liamcervante commented Sep 13, 2022

Fixes issue raised in #479 (comment)

Apologies, not sure of the process for raising PRs but this seemed very simple so I thought I'd give it a go. Feel free to close this if this needs to be tracked in a different way.

@bflad
Copy link
Member

bflad commented Sep 13, 2022

Hi @liamcervante 👋 Thanks for submitting this fix. I think this is an appropriate code change that was missed in #468 so thank you for catching it.

Would you like to finish up this pull request or leave it for us? In order to get this in, let's:

  • Ensure there is a changelog entry file created, e.g. .changelog/480.txt with contents such as:
```release-note:bug
internal/fwserver: Ensured nested block plan modifiers correctly set their request `AttributeConfig`, `AttributePlan`, and `AttributeState` values
```
  • Ensure there is a covering unit test in block_plan_modification_test.go since it was already missing before. This may be non-trivial/verbose to implement, so don't feel like you should spend too much time here. The block-set-nested-usestateforunknown test case might be a good starting point to copy-paste-modify. 👍

Thanks again.

@bflad bflad added the bug Something isn't working label Sep 13, 2022
@bflad bflad added this to the v0.13.0 milestone Sep 13, 2022
@bflad bflad self-assigned this Sep 13, 2022
@liamcervante
Copy link
Member Author

I will work on this today!

@liamcervante liamcervante marked this pull request as ready for review September 14, 2022 08:58
@liamcervante liamcervante requested a review from a team as a code owner September 14, 2022 08:58
@liamcervante
Copy link
Member Author

Ready for review!

Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, @liamcervante 🚀

@bflad bflad merged commit 9696464 into hashicorp:main Sep 14, 2022
@liamcervante liamcervante deleted the liamcervante/nested-block-list-fix branch September 14, 2022 16:03
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants