Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/fwserver: Prevent two sources of errors/panics #475

Merged
merged 1 commit into from Sep 12, 2022
Merged

internal/fwserver: Prevent two sources of errors/panics #475

merged 1 commit into from Sep 12, 2022

Commits on Sep 9, 2022

  1. internal/fwserver: Prevent two sources of errors/panics 

    Previously, it was possible to get a `Attribute Plan Modification Walk Error` diagnostic when a resource was being created and the `req.AttributeState` was set to `nil` instead of a null value for the given `attr.Value`. This changes the logic to always return a proper `attr.Value`.

Previously, it was possible that while iterating through the plan elements for a list or set collection, that configuration or state elements at the same index may not exist. The logic was off-by-one due to Go's 0-based slice indexing to return early with a null value in those cases.
    @bflad
    bflad committed Sep 9, 2022
    Copy the full SHA
    b034890 View commit details
    Browse the repository at this point in the history