Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Migration guide updates for provider.DataSourceType and provider.ResourceType deprecation #473

Merged
merged 4 commits into from Sep 13, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Sep 9, 2022

Reference: #472

Note: The source code reference links to the http, random, and tls providers will be out of date until they are migrated after this functionality is released in the framework. I'm guessing we should hold off merging this until after they are migrated?

@bflad bflad requested a review from a team as a code owner September 9, 2022 15:54
@bflad bflad added the documentation Improvements or additions to documentation label Sep 9, 2022
@bendbennett
Copy link
Contributor

Reference: #472

Note: The source code reference links to the http, random, and tls providers will be out of date until they are migrated after this functionality is released in the framework. I'm guessing we should hold off merging this until after they are migrated?

We could update the migration docs to remove source code links and replace with generic code examples?

Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad added this to the v0.13.0 milestone Sep 13, 2022
@bflad
Copy link
Member Author

bflad commented Sep 13, 2022

I think I caught all the links pointing to code that was updated.

We could update the migration docs to remove source code links and replace with generic code examples?

I'm generally a proponent of this approach as we can show code with only the necessary context and without needing to update links while the framework is under development, but that can be an exercise done separately. 👍

@bflad bflad merged commit 6dd6fbe into main Sep 13, 2022
@bflad bflad deleted the bflad/provider-refactoring-migration-docs-2 branch September 13, 2022 13:20
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants