Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/fwserver: Use existing data instead of path-based lookups during plan modification #468

Merged
merged 5 commits into from Sep 8, 2022
Merged

internal/fwserver: Use existing data instead of path-based lookups during plan modification #468

merged 5 commits into from Sep 8, 2022

Commits on Sep 7, 2022

  1. internal/fwserver: Use existing data instead of path-based lookups du… 

    …ring plan modification

Reference: #293

This change is a major rewrite of the plan modification logic to move away from globally mutating the schema response to instead localize handling of each attribute/block. The logic still transverses downward in the schema while updated plan modifier values are passed up the call stack to eventually overwrite the top level attribute/block data. The main benefit of this logic is that it cannot lose track of which element to update within a set and may have some nominal performance improvements.

The majority of the logic changes are convincing the plan modification process that nested attributes and blocks have specific types for their data, which allows it to safely traverse deeper based on the schema definition. There is just a lot of repeated diagnostics handling.
    @bflad
    bflad committed Sep 7, 2022
    Copy the full SHA
    8fd6726 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG for #468

    @bflad
    bflad committed Sep 7, 2022
    Copy the full SHA
    bd17b8b View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG for #468

    @bflad
    bflad committed Sep 7, 2022
    Copy the full SHA
    9977f17 View commit details
    Browse the repository at this point in the history

  4. Update internal/fwserver/attr_value.go 

    Co-authored-by: Benjamin Bennett <ben.bennett@hashicorp.com>
    @bflad @bendbennett
    bflad and bendbennett committed Sep 7, 2022
    Copy the full SHA
    ec49aeb View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into bflad/plan-modification-rewrite

    @bflad
    bflad committed Sep 7, 2022
    Copy the full SHA
    b089e47 View commit details
    Browse the repository at this point in the history