Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/fwserver: Add unit test for no configuration change plan which has modified and unmodified Computed attributes #463

Merged
merged 2 commits into from
Aug 30, 2022
Merged

internal/fwserver: Add unit test for no configuration change plan which has modified and unmodified Computed attributes #463

merged 2 commits into from
Aug 30, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Aug 29, 2022

Reference: #183
Reference: #456

@bflad
internal/fwserver: Add unit test for no configuration change plan whi…
498f593 
…ch has modified and unmodified Computed attributes

Reference: #183
Reference: #456
@bflad bflad requested a review from a team as a code owner August 29, 2022 15:00
bendbennett
bendbennett approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad added this to the v0.12.0 milestone Aug 30, 2022
@bflad bflad merged commit 1a3f8fe into main Aug 30, 2022
@bflad bflad deleted the bflad/plan-second-null-to-unknown branch August 30, 2022 14:34
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bendbennett bendbennett bendbennett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bflad @bendbennett