Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding docs for migrating from SDKv2 to the Framework #461
Adding docs for migrating from SDKv2 to the Framework #461
Changes from 1 commit
fe9d1f2
7e6158f
45718ce
92724f4
2cf4cf6
3fe19bc
77793a8
0b5c8c3
0b9f120
e0eb531
f5c4be6
0e3d07b
d781d32
d654477
9314e01
474c8bb
653c65c
a86abfb
84fd690
017d416
1ae0d44
1afd243
7a07a06
3566d84
be4cb9e
64b35fc
f07b3e2
d14ee0d
73879d7
62e9ec0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we have a Schema section, should these pages be moved under there as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that makes sense given that each of these pages relates to how the schema is set-up.
@laurapacilio @robin-norwood are you happy if I go ahead and move these pages as @bflad suggests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you get a chance, you can try running
markdownlint
CLI against these files to catch things like this:And further down with additional newlines after code fences. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have installed and run
markdownlint --disable MD013 -- ./website/docs/plugin/framework/migrating/*
.I'm ignoring the
MD013/line-length Line length
notifications.In terms of the remaining notifications, I'm interested to hear feedback from @robin-norwood and @laurapacilio as I thought this was intentional but happy to fix however suits:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgive me - is the problem that we have duplicate headings? My opinion is that they are needed here, but let me know if you disagree!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2 things that are being flagged by the linter are:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the removal of
**SDKv2**
and**Framework**
, we now have the following: