Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: Go package documentation updates post datasource, provider, and resource package migration #436

Merged
merged 1 commit into from Aug 3, 2022
Merged

all: Go package documentation updates post datasource, provider, and resource package migration #436

merged 1 commit into from Aug 3, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Aug 2, 2022

Reference: #432

@bflad bflad added the documentation Improvements or additions to documentation label Aug 2, 2022
@bflad bflad added this to the v0.11.0 milestone Aug 2, 2022
@bflad bflad requested a review from a team as a code owner August 2, 2022 16:29
bendbennett
bendbennett approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expanded comments really provide an excellent improvement in clarity.
LGTM

@bflad bflad merged commit 46c9ee1 into main Aug 3, 2022
@bflad bflad deleted the bflad/dspr-refactoring-go-docs branch August 3, 2022 11:01
@github-actions
Copy link

github-actions bot commented Sep 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bendbennett bendbennett bendbennett approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bflad @bendbennett