New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using UnmarshalWithOpts in order to ignore undefined attributes #426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes here looks good -- could you add a CHANGELOG entry file? Maybe something like
```release-note:bug
internal/fwserver: Ensured `UpgradeResourceState` calls from Terraform 0.12 properly ignored attributes not defined in the schema
```
I think we'll also need to update the |
4b83e22
to
489ea99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! A go mod tidy
and this should be good to merge. 🚀
Merging so I can update and merge in some other things. 😄 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Closes: #415
During unmarshalling of JSON, if there are fields which do not have a corresponding attribute in the schema an error is returned.
A PR on terraform-plugin-go addresses this issue.
The
UnmarshalWithOpts
function used in this PR will not be available toterraform-plugin-framework
until the PR onterraform-plugin-go
has been merged, tagged and released. Consequently, the build will fail on this PR until that time.