-
Notifications
You must be signed in to change notification settings - Fork 91
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Text objects, fix slices, simplify primitives.
Add some more tests for object to struct conversion. Remove a log line. Oops. Simplify primitives by passing a concrete type to tftypes.Value.As and then setting a reflect.Value from the result. This avoids shenanigans around pointers on reflect.Value types. Make elements of a slice always settable by adding the reflect.Value to the slice, then retrieving it by index, before recursing into it with the `into` function. This means even when we add a new reflect.Value to a slice, we can still set its value. Add TODOs for the object tests we should probably write and the fact that we've just ignored maps entirely so far.
- Loading branch information
1 parent
96c90fc
commit 0c319ba
Showing
6 changed files
with
129 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters