Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move schemamd and functionmd packages to internal #354

Merged
merged 3 commits into from Apr 11, 2024

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Apr 10, 2024

The schemamd and functionmd packages create markdown documentation from the terraform-json representation of the provider schema and the function definition respectively for the generate command. These packages were never meant to be exposed as public packages and lack sufficient documentation as expected of such. This PR moves these packages to internal, so that it could no longer be imported as public packages.

@SBGoods SBGoods requested a review from a team as a code owner April 10, 2024 20:21
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question about whether this represents breaking changes and if so whether this should be reflected in the change log entries.

.changes/unreleased/NOTES-20240410-161445.yaml Outdated Show resolved Hide resolved
.changes/unreleased/NOTES-20240410-161540.yaml Outdated Show resolved Hide resolved
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

.changes/unreleased/NOTES-20240410-161445.yaml Outdated Show resolved Hide resolved
@SBGoods SBGoods added this to the v0.19.0 milestone Apr 11, 2024
@SBGoods SBGoods merged commit 1f28b7c into main Apr 11, 2024
6 checks passed
@SBGoods SBGoods deleted the refactor-schemamd-functionmd branch April 11, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants