Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated template file to fix whitespace issue. #237

Merged
merged 3 commits into from Mar 30, 2023

Conversation

YanniHu1996
Copy link
Contributor

Updated template file to keep whitespace appear once at the end of the file

@YanniHu1996 YanniHu1996 requested a review from a team as a code owner March 20, 2023 05:17
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 20, 2023

CLA assistant check
All committers have signed the CLA.

@serdardalgic
Copy link

If there is no import defined for a resource, tfplugindocs generates empty whitespaces at the end of the generated document.

This PR is fixing this issue. For our provider, we need this change, is there anything we can do to support you folks?

Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there 👋🏻 , thanks for the PR! I left one small suggestion.

internal/provider/template.go Outdated Show resolved Hide resolved
Co-authored-by: Austin Valle <austinvalle@gmail.com>
@YanniHu1996
Copy link
Contributor Author

Thanks @austinvalle and @serdardalgic 👍 , I taken the suggestion of @austinvalle

Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @YanniHu1996 & @serdardalgic !

@austinvalle austinvalle merged commit e8f8eb1 into hashicorp:main Mar 30, 2023
@austinvalle
Copy link
Member

The change will be released with our next feature or bug release of terraform-plugin-docs, although we don't currently have a plan for that next release.

In the meantime, you can install the commit (e8f8eb1) specific version of the tool (or branch, whatever better fits your need):

go get -u github.com/hashicorp/terraform-plugin-docs@e8f8eb1f6dbb047551ceedd48e7810c6c6661d03 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants