Group nested attributes by optional, required and read-only #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alessiodionisi
changed the title
alessiodionisi
changed the title
|
Hey @adnsio - thank you for this. Given this is going to result in a change in behaviour, this is likely requiring a minor release ( Additionally, this might require me to do some manual testing, as the current regression testing automation in this repository is wanting. |
detro
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation the docs of a nested schema use the title (optional, required and read-only) of the parent. With this PR the attributes of the nested schema will be grouped according to their settings.
Demo: https://registry.terraform.io/providers/adnsio/k0s/latest/docs/resources/cluster