Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default id to "Read-Only" + allow for empty blocks/nested attributes to be documented #134

Merged
merged 5 commits into from May 3, 2022
Merged

Default id to "Read-Only" + allow for empty blocks/nested attributes to be documented #134

merged 5 commits into from May 3, 2022

Commits on Apr 29, 2022

  1. Treat empty blocks with MinItems == 0 as optional

    @ovandriyanov
    ovandriyanov authored and Ivan De Marino committed Apr 29, 2022
    Copy the full SHA
    0a567c5 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. Adding CHANGELOG entry for the work done in #99 and cherry-picked here

    Ivan De Marino committed May 3, 2022
    Copy the full SHA
    e78907e View commit details
    Browse the repository at this point in the history

  2. Place id attribute in documentation "Read-Only" group by default 

    This still allows arbitrary definition of `id` where a tailor-made `.Description` can be provided: it's just the default that is changing to something more sensible.

Also, updated README to guide developers.

Co-authored-by: Nicholas Muesch <nicholas.muesch@datadoghq.com>
Co-authored-by: Oliver Ford <dev.github@ojford.com>
    @nmuesch @OJFord
    3 people committed May 3, 2022
    Copy the full SHA
    f146f84 View commit details
    Browse the repository at this point in the history

  3. Add correct link to PR that implements the bugfix

    Ivan De Marino committed May 3, 2022
    Copy the full SHA
    d8e70fb View commit details
    Browse the repository at this point in the history

  4. Fixing test fixtures

    Ivan De Marino committed May 3, 2022
    Copy the full SHA
    08f8848 View commit details
    Browse the repository at this point in the history