Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read go version from .go-version on GitHub Actions #210

Merged
merged 2 commits into from Jul 7, 2020

Conversation

jojo43
Copy link
Contributor

@jojo43 jojo43 commented Jul 4, 2020

As written in the comment, I fixed it to read version from .go-version instead of hard-coding.

@radeksimko
Copy link
Member

radeksimko commented Jul 4, 2020

Hey @jojo43
Thanks for the contribution. I'll read through more thoroughly next week, but just to be honest and transparent I was more hoping to see this solved in the context of the existing Go action as per actions/setup-go#23 (comment)

I think this is a decent temporary solution too, but have you considered contributing to that repository? I think that native support would significantly simplify the configuration and help avoiding the extra step.

Most importantly it would solve the problem for everyone, not just this repository.

@radeksimko radeksimko added the ci Continuous integration/delivery related label Jul 4, 2020
@jojo43
Copy link
Contributor Author

jojo43 commented Jul 4, 2020

I was more hoping to see this solved in the context of the existing Go action

I totally agree you. 👍

have you considered contributing to that repository?

I've never, but going to look into it!

@jojo43
Copy link
Contributor Author

jojo43 commented Jul 5, 2020

I opened a PR: actions/setup-go#62

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I just added a comment linking to your PR, so we don't forget to update the actions when it gets merged.

@radeksimko radeksimko merged commit aa04dcc into hashicorp:master Jul 7, 2020
@jojo43 jojo43 deleted the read-go-version branch July 7, 2020 12:24
@ghost
Copy link

ghost commented Aug 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@hashicorp hashicorp locked and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants