Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable Dependabot for internal GitHub actions #455

Merged
merged 3 commits into from
May 13, 2024

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented May 13, 2024

When TSCCR was first introduced, it was not clear that the tool would only update external GitHub actions. This adds the configuration to enable hashicorp/* action updates.

@dbanck dbanck added the dependencies Auto-pinning label May 13, 2024
Copy link
Member

@xiehan xiehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jinx, I was just about to submit the same PR. Here's where mine differs slightly from yours.

.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
dbanck and others added 2 commits May 13, 2024 14:25
Co-authored-by: Nara Kasbergen Kwon <855115+xiehan@users.noreply.github.com>
@dbanck
Copy link
Member Author

dbanck commented May 13, 2024

GitHub has recently updated the macos-latest runners from amd64 to arm64: https://github.blog/changelog/2024-04-01-macos-14-sonoma-is-generally-available-and-the-latest-macos-runner-image/. Older versions of Terraform aren't available for arm64, hence the failed tests.

It might make sense for this repository to use macos-13 instead.

@dbanck dbanck merged commit c07c678 into main May 13, 2024
10 of 13 checks passed
@dbanck dbanck deleted the c-dependabot-for-internal-actions branch May 13, 2024 12:50
@bflad
Copy link
Member

bflad commented May 13, 2024

FYI, in case it helps -- hashicorp/setup-terraform v3.1.0+ will automatically install darwin/amd64 when running on darwin/arm64 for Terraform versions 1.0.2 and earlier which didn't have that release artifact. For example, we still wanted legacy Terraform version coverage with provider acceptance testing on macOS and it seemed like a pragmatic compromise until those legacy Terraform versions are officially deprecated. It'll work as long as Apple/GitHub continue to enable the CPU emulation support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Auto-pinning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants