tfexec: add InterruptChannel option to allow a user triggered interrupt #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
twmb
force-pushed
the
twmb/interrupt-channel
branch
2 times, most recently
from
8004d24
to
fe44afb
Compare
This is an alternative to hashicorp#332, adding an option that enables the user to implement graceful shutdowns for Apply and Destroy operations. Rather than adding an option that changes the behavior of the input context, we instead add an option that specifically sends an interrupt to the terraform process. The input context behavior remains unchanged. This requires the caller to do a bit more orchestration work for timeouts, but keeps context truer to the "abandon work" intent. This also allows users to force quit _even if_ they are in the middle of a graceful shutdown, rathern than having one behavior mutually exclusive with the other.
twmb
force-pushed
the
twmb/interrupt-channel
branch
from
fe44afb
to
06beb79
Compare
simon0191
reviewed
Sep 1, 2022
tfexec/cmd_default.go
Outdated
| go func() { | ||
| select { | ||
| case <-interruptCh.(<-chan struct{}): | ||
| cmd.Process.Signal(os.Interrupt) |
There was a problem hiding this comment.
I think SIGINT is not available in Windows and that's what's making the test to fail 🤔
There was a problem hiding this comment.
I'm wondering why cmd_linux can't be used for macos as well?
There was a problem hiding this comment.
I've made cmd_linux -> cmd_unix as the implementation should work in all unix systems
44715fe
simon0191
force-pushed
the
twmb/interrupt-channel
branch
2 times, most recently
from
32b2eb7
to
6594828
Compare
All unix platforms should support SIGKILL and SIGINT. This change uses the implementation of cmd that sends SIGKILL and SIGINT in all unix platforms. The list of platform tags is extracted from go/build/syslist.go and emulates what's done by the unix build tag introduced in go1.19.
simon0191
force-pushed
the
twmb/interrupt-channel
branch
from
6594828
to
24313c4
Compare
|
is there any update about this feature request and this PR? cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #332, adding an option that enables the user
to implement graceful shutdowns for Apply and Destroy operations.
Rather than adding an option that changes the behavior of the input
context, we instead add an option that specifically sends an interrupt
to the terraform process. The input context behavior remains unchanged.
This requires the caller to do a bit more orchestration work for
timeouts, but keeps context truer to the "abandon work" intent. This
also allows users to force quit even if they are in the middle of a
graceful shutdown, rathern than having one behavior mutually exclusive
with the other.
Refs