Canceling Terraform Command #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…timeframe
Add a timeout to the test to ensure that the terraform apply cancels within
a reasonable time of the 5s timeout.
Currently, this test is not canceling the terraform apply as expected. In the
logs you can see that the test takes 1 min rather than ~5s:
```
--- PASS: TestContext_sleepTimeoutExpired/sleep-0.12.31 (62.13s)
```
```
=== RUN TestContext_sleepTimeoutExpired/sleep-0.12.31
util_test.go:113: [INFO] running Terraform command: /var/folders/6y/gy9gggt14379c_k39vwb50lc0000gn/T/terraform_1378921380/terraform apply -no-color -auto-approve -input=false -lock=true -parallelism=10 -refresh=true
util_test.go:103: CLI Output:
// truncated ...
time_sleep.sleep: Creating...
time_sleep.sleep: Still creating... [10s elapsed]
time_sleep.sleep: Still creating... [20s elapsed]
time_sleep.sleep: Still creating... [30s elapsed]
time_sleep.sleep: Still creating... [41s elapsed]
time_sleep.sleep: Still creating... [51s elapsed]
time_sleep.sleep: Creation complete after 1m0s [id=2022-05-06T17:40:20Z]
Apply complete! Resources: 1 added, 0 changed, 0 destroyed.
```
Processes were not being killed because cmd.ProcessState was nil. With this change, processes will be able to make the request to Kill(). Added a temporary log to printout cmd.ProcessState to demonstrate. Will be removed in next commit. Note: this will cause hanging `TestContext_sleepTimeoutExpired` due to a known Golang issue with killing a command when Stdout or Stderr are set to anything besides `nil` or `*os.File`. This is because the Kill does not notify the stdout/stderr subprocesses to stop. `cmd.Wait` (called by `cmd.Run`) waits indefinitely for those subprocesses to stop.
`TestContext_sleepTimeoutExpired` can occasionally hang when killing a command that has Stdout or Stderr set to anything besides `nil` or `*os.File`. golang/go#23019 Use workaround to read from StdoutPipe and StderrPipe rather than setting Stdout / Stderr
|
Closed since it is a sub-set of changes in #299 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Commits (see message for more details, sample logs, and progression of working through issue)
TestContext_sleepTimeoutExpiredto check if the Terraform Apply is killed within a reasonable timeframe of the cancel (test fails because terraform apply is not killed)