Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Upgrade yargs to v17 #779

Merged
merged 4 commits into from Aug 26, 2021
Merged

chore(deps): Upgrade yargs to v17 #779

merged 4 commits into from Aug 26, 2021

Conversation

skorfmann
Copy link
Contributor

Looks like we're running a pretty old version of yargs. One of the transitive dependencies of the old version had a security vulnerability which should be fixed by upgrading to the latest version. It doesn't look really critical, but it's probably still a good idea to do the upgrade nevertheless.

The changes in yargs:

@ansgarm
Copy link
Member

ansgarm commented Jun 29, 2021

This currently fails because yargs dropped support for NodeJS v10. As v10 had its end of life a few months ago I think we could just drop support for v10 as well.

@ansgarm
Copy link
Member

ansgarm commented Jul 29, 2021

rebased this onto main as we now are on Node 14 and this should resolve the Node 10 issue

@skorfmann skorfmann merged commit e838ea8 into main Aug 26, 2021
@skorfmann skorfmann deleted the upgrade-yargs branch August 26, 2021 19:45
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants