Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): ensure a copy of the license is included with published packages #3617

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

xiehan
Copy link
Member

@xiehan xiehan commented May 8, 2024

This PR does two things which are similar but not the same:

  • It attempts to make us compliant with a new organizational requirement to include a copy of the license file with all of our releases. The actual packaging process is a little bit opaque to me so I'm not 100% positive this solution works across all languages but I was able to verify at the very least that it works as expected for JS.
  • It also attempts to make us compliant with what I assume is a long-standing requirement to generate a NOTICES.txt file with all the third-party dependency licenses that we've never followed. AFAIK this is not currently being enforced and I don't know whether they will start enforcing it, but I was curious about whether there's tooling out there to automate this and found that it was easier to implement than I'd expected, so I figured why not push that change as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant