New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove dependency on jsii-srcmak #3607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
force-pushed
the
remove-dependency-on-jsii-srcmak
branch
from
April 29, 2024 07:28
74dcafa
to
a7d0fd3
Compare
DanielMSchmidt
force-pushed
the
remove-dependency-on-jsii-srcmak
branch
from
April 29, 2024 07:36
021d676
to
47634e9
Compare
DanielMSchmidt
force-pushed
the
remove-dependency-on-jsii-srcmak
branch
from
May 6, 2024 09:16
47634e9
to
dd550a1
Compare
DanielMSchmidt
force-pushed
the
remove-dependency-on-jsii-srcmak
branch
from
May 6, 2024 09:52
dd550a1
to
d19bc10
Compare
DanielMSchmidt
requested review from
mutahhir and
ansgarm
and removed request for
a team
May 6, 2024 11:42
xiehan
force-pushed
the
remove-dependency-on-jsii-srcmak
branch
from
May 8, 2024 14:58
d19bc10
to
01cafc7
Compare
DanielMSchmidt
force-pushed
the
remove-dependency-on-jsii-srcmak
branch
from
May 13, 2024 07:57
01cafc7
to
701d800
Compare
ansgarm
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
mutahhir
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.