Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: manifest.json should have stable json #3584

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mutahhir
Copy link
Contributor

@mutahhir mutahhir commented Apr 8, 2024

Description

Ensure that the manifest.json file has stable output. Removes instances where test snapshots fail when no content has changed, but JSON.stringify shuffles object attribute order. Suggested by #3561

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants