fix: add completed tfc pending states #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaellzc
requested review from
mutahhir and
DanielMSchmidt
and removed request for
a team
2 tasks
michaellzc
changed the title
michaellzc
force-pushed
the
patch-a6c460b
branch
from
e4f0ab3
to
4059502
Compare
ansgarm
reviewed
Dec 6, 2022
ansgarm
approved these changes
Dec 6, 2022
Merged
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issues & pr:
While #1955 is currently being worked on, this is the workaround for various causes of the issue described in #2232
Context
#2243 & #2360 are missing a few more pending states from TFC API
Testing
This is tested internally across our TFC workspaces with and without auto-apply enabled. I can confirm no more
409error from TFC and all stacks are deployed in one go.