Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): prompt added in init - asks to use TFC when credentials are present #2386

Merged
merged 2 commits into from Dec 5, 2022

Conversation

Maed223
Copy link
Contributor

@Maed223 Maed223 commented Dec 2, 2022

Closes: #2280

If user has TFC credentials present (~/.terraform.d/credentials.tfrc.json exists) they are prompted to confirm the usage of TFC in cdktf init.

Link to gist demonstrating

@Maed223 Maed223 requested a review from a team as a code owner December 2, 2022 21:41
@Maed223 Maed223 requested review from ansgarm and DanielMSchmidt and removed request for a team December 2, 2022 21:41
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👍

@DanielMSchmidt DanielMSchmidt merged commit 2f69e12 into main Dec 5, 2022
@DanielMSchmidt DanielMSchmidt deleted the init-prompt-when-tfc-detected branch December 5, 2022 14:22
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDK init allow to choose to use Terraform cloud if detected
3 participants