fix: add required_version
to json schema
#2355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
8b069eb added validation on the
cdk.tf.json
file. However, the schema is missing required_version in theterraform
blockhence when running
cdktf [deploy|plan|destroy]
will result in the following errorNote
There is another terraform json schema at https://sourcegraph.com/github.com/daniel-laszlo/terraform-cdk/-/blob/packages/@cdktf/hcl2cdk/lib/schema.ts?L22
I do not have any historical context on this project, but should there only be one?
Another note
required_version
is not supported by cdktf natively yet (at least last time I check), we currently use the escape hatch in an aspect to addrequired_version
in every stack