New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add expression paranthesis #2332
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ddaedba
chore: add expression paranthesis
DanielMSchmidt 87c2118
chore: remove matrix from unit test workflow
DanielMSchmidt 5ce2b0a
chore: use only one trigger
DanielMSchmidt ef42aaa
chore: trigger CI by labels only
DanielMSchmidt a34f865
chore: add debugging job
DanielMSchmidt 6d82412
chore: try again
DanielMSchmidt 66583ec
chore: remove debugging step
DanielMSchmidt 2a5231f
chore: ensure caching dirs are in place
DanielMSchmidt 5aa99a4
chore: correct package name
DanielMSchmidt a0a3689
chore: fix unit tests
DanielMSchmidt 787a90f
chore: fix mocking
DanielMSchmidt bc19f2d
chore: fix dist path
DanielMSchmidt e23651a
chore: always release a next version
DanielMSchmidt 15a7554
chore: fix documentation example
DanielMSchmidt 43dfb85
chore: remove JSII runtime dependency
DanielMSchmidt c24702a
chore: remove warning level
DanielMSchmidt File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
ci/run-unit/@cdktf/cli-core: | ||
# The workflow used | ||
- ".github/workflows/unit.yml" | ||
# All packages under test | ||
- "packages/@cdktf/cli-core/**" | ||
# All scripts we use | ||
- "tools/align-version.sh" | ||
|
||
ci/run-unit/@cdktf/commons: | ||
# The workflow used | ||
- ".github/workflows/unit.yml" | ||
# All packages under test | ||
- "packages/@cdktf/commons/**" | ||
# All scripts we use | ||
- "tools/align-version.sh" | ||
|
||
ci/run-unit/@cdktf/hcl2cdk: | ||
# The workflow used | ||
- ".github/workflows/unit.yml" | ||
# All packages under test | ||
- "packages/@cdktf/hcl2cdk/**" | ||
# All scripts we use | ||
- "tools/align-version.sh" | ||
|
||
ci/run-unit/@cdktf/hcl2json: | ||
# The workflow used | ||
- ".github/workflows/unit.yml" | ||
# All packages under test | ||
- "packages/@cdktf/hcl2json/**" | ||
# All scripts we use | ||
- "tools/align-version.sh" | ||
|
||
ci/run-unit/@cdktf/provider-generator: | ||
# The workflow used | ||
- ".github/workflows/unit.yml" | ||
# All packages under test | ||
- "packages/@cdktf/provider-generator/**" | ||
# All scripts we use | ||
- "tools/align-version.sh" | ||
|
||
ci/run-unit/cdktf-cli: | ||
# The workflow used | ||
- ".github/workflows/unit.yml" | ||
# All packages under test | ||
- "packages/cdktf-cli/**" | ||
# All scripts we use | ||
- "tools/align-version.sh" | ||
|
||
ci/run-unit/cdktf: | ||
# The workflow used | ||
- ".github/workflows/unit.yml" | ||
# All packages under test | ||
- "packages/cdktf/**" | ||
# All scripts we use | ||
- "tools/align-version.sh" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 14 additions & 3 deletions
17
.github/workflows/pr-size.yml → .github/workflows/pr-labels.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering whether we could simplify this config by adding
ci/run-unit
with those two repeated files (that are common for all individual unit labels currently). It would then effectively run all unit tests if we change those files while not spamming the PR with all individual unit test labels 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, will do it in a follow-up though