Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: limit concurrency on releases #2318

Merged
merged 2 commits into from Nov 21, 2022
Merged

Conversation

DanielMSchmidt
Copy link
Contributor

No description provided.

@@ -15,6 +15,10 @@ env:
SENTRY_ORG: hashicorp
SENTRY_PROJECT: cdktf-cli

concurrency:
group: release
cancel-in-progress: true
Copy link
Member

@ansgarm ansgarm Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this be dangerous? 😅
If something is merged while a release is running? Is there something we can do to safeguard that case other than "don't merge while we release a new version" 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point! I looked it up and the default is what we want. TL;DR: no canceling, everything else gets queued, if there is already something queued only the last one gets executed, the rest skipped.

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants