Skip to content

Commit

Permalink
fix(cli): fix version detection for Java being a bit too optimistic a…
Browse files Browse the repository at this point in the history
…bout the package name

Resolves #1994
  • Loading branch information
ansgarm committed Aug 3, 2022
1 parent b776e64 commit cb3d155
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion packages/cdktf-cli/lib/debug.ts
Expand Up @@ -253,9 +253,12 @@ async function getJavaPackageVersion(packageName: string) {
return undefined;
}

// We need to search for the package name AND a colon to not match a line like
// [INFO] com.hashicorp:cdktf-provider-aws:jar:9.0.9:compile
// when looking for the cdktf package (see Github issue #1994)
const versionLine = resolutionPart
.split(/\r\n|\r|\n/)
.find((line) => line.includes(javaPackageName));
.find((line) => line.includes(`${javaPackageName}:`));

if (!versionLine) {
logger.debug(
Expand Down

0 comments on commit cb3d155

Please sign in to comment.