Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape backticks in stdout and stderr #402

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

manabusakai
Copy link

Thank you for an awesome actions! 😄
fixes #401

The stdout of validate or plan may contain backticks. If backticks are included, problems like #401 will occur.

Fix this problem by escaping the backticks.

@manabusakai manabusakai requested a review from a team as a code owner March 13, 2024 14:56
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 13, 2024

CLA assistant check
All committers have signed the CLA.

@bflad
Copy link
Member

bflad commented Mar 19, 2024

Hi @manabusakai 👋 Thank you for submitting this.

This seems reasonable on the surface, however it is not clear whether this should be an automatic behavior of this particular GitHub Action. While you are passing the output to an action that is sensitive to particular characters, other workflows may be dependent on the existing behavior and introducing the escaping could introduce a regression. This submission does not do this, but just to mention, it also seems awkward to potentially introduce this as a configurable action option, for such a targeted use case.

While we wait for other maintainers to offer their opinions, you may want to check out other GitHub Actions that seem to implement this functionality, such as https://github.com/marketplace/actions/find-and-replace-strings. I cannot endorse this particular action as I have never used it myself, but it (or another similar action) should hopefully get the job done for your use case.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escape backticks in stdout and stderr
3 participants