Fix terraform extract #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I identified that I had set a variable to be constant rather than mutable. added a commit to fix that. Validated within a private GitHub workflow this morning that it functions as expected. (Well, it happens to be morning where I am right now) |
cpc-dossaa
approved these changes
Apr 28, 2022
|
Thanks for the contribution @cpc-camarj! I'll be able to review this tomorrow, but it looks good so far. |
jpogran
approved these changes
May 9, 2022
|
Apologies for the delay in merging. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows runners, extracting the downloaded CLI zip file was failing because the file didn't have a
.zipextension. This PR attempts to solve the problem by adding the extension to the downloaded file before extraction.(fixes #186)