Upgrade armon/go-metrics to hashicorp/go-metrics #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also bumping hashicorp/memberlist to the corresponding version which also uses hashicorp/go-metrics
mkeeler
requested review from
JadhavPoonam and
rboyer
and removed request for
a team,
JadhavPoonam and
rboyer
|
can someone merge it, please? |
|
+1 here I need to the line below several
|
|
fix issue #707 |
|
+1 here |
|
any reason to not merge it ? |
|
@mkeeler @hashi-derek can we get some 👀 on this? |
|
Bump please; without this patch, this library is completely unusable/broken for anyone using it, or pulling in something that uses it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bumping hashicorp/memberlist to the corresponding version which also uses hashicorp/go-metrics
This will require a new major version to signify that metrics are using different global handlers.
TODO: