Fix race with candidateFromLeadershipTransfer
#570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhiaayachi
requested review from
JadhavPoonam
and removed request for
a team
ncabatoff
approved these changes
Sep 25, 2023
JadhavPoonam
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #517
candidateFromLeadershipTransferis used to notify that a leadership transfer is ongoing and transition nodes to candidate state directly without going through follower state. As a leader is already in place transitioning to follower state will avoid leadership transfer happening.This PR fix a race condition as this bool ,
candidateFromLeadershipTransfer, is read in the appendEntries processing while written in the state processing routine (in both runCandidate and possibly runFollower).See #517 for a stack trace of the Data Race