Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gofumpt #562

Merged
merged 4 commits into from Jul 3, 2023
Merged

gofumpt #562

merged 4 commits into from Jul 3, 2023

Conversation

mpalmi
Copy link
Contributor

@mpalmi mpalmi commented Jul 3, 2023

This PR resolves some issues in CI when modifying api.go.

@mpalmi mpalmi requested a review from banks July 3, 2023 19:47
@mpalmi mpalmi requested a review from a team as a code owner July 3, 2023 19:47
@@ -1,6 +1,7 @@
// Copyright (c) HashiCorp, Inc.
// SPDX-License-Identifier: MPL-2.0

//go:build batchtest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the minimum version of Go that supports this syntax? I suggest we bump go.mod to that version to avoid surprises.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 17 to 18
"github.com/hashicorp/go-hclog"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"github.com/hashicorp/go-hclog"
"github.com/hashicorp/go-hclog"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ removing the extra newline

Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mpalmi mpalmi merged commit b650ad6 into main Jul 3, 2023
6 checks passed
@mpalmi mpalmi deleted the gofumpt branch July 3, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants