Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding changelog for 1.4.0 #550

Merged
merged 1 commit into from Mar 17, 2023
Merged

Adding changelog for 1.4.0 #550

merged 1 commit into from Mar 17, 2023

Conversation

jmurret
Copy link
Contributor

@jmurret jmurret commented Mar 17, 2023

No description provided.

@jmurret jmurret requested a review from a team as a code owner March 17, 2023 18:18
@jmurret jmurret requested review from erichaberkorn, banks and dhiaayachi and removed request for a team March 17, 2023 18:18
@dhiaayachi
Copy link
Contributor

dhiaayachi commented Mar 17, 2023 •
edited

🤔 This changelog seem to be missing all the changes in minor version. Are they supposed to be in it?

@jmurret
Copy link
Contributor Author

jmurret commented Mar 17, 2023

I'm not sure of the history with that, but if we have to backfill it, I would like to add an issue for that and address it after this is released.

banks
banks approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks!

@jmurret jmurret merged commit a3acea6 into main Mar 17, 2023
@jmurret jmurret deleted the jm/1.4.0 branch March 17, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banks banks banks approved these changes

@erichaberkorn erichaberkorn Awaiting requested review from erichaberkorn erichaberkorn is a code owner automatically assigned from hashicorp/consul-core-reviewers

@dhiaayachi dhiaayachi Awaiting requested review from dhiaayachi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmurret @dhiaayachi @banks