Forbid removed node from being a Candidate
#476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhiaayachi
force-pushed
the
removed-node-vote
branch
from
fb6efb9
to
9f012d8
Compare
5 tasks
dhiaayachi
changed the title
Candidate or voteCandidate
mkeeler
approved these changes
Oct 5, 2021
dhiaayachi
added a commit
that referenced
this pull request
Oct 7, 2021
* modify `TestRaft_RemoveFollower` to check removed node state * add test to verify that a removed node is not able to vote * do not transition to `Candidate` state if not part of stable configuration * add some comments to the tests * do not return if not transitioning state * add wait loop to test * remove test related to removed node voting * check `inConfig` instead of `hasVote` * updating warn log message to be more accurate
dhiaayachi
added a commit
that referenced
this pull request
Oct 12, 2021
* modify `TestRaft_RemoveFollower` to check removed node state * add test to verify that a removed node is not able to vote * do not transition to `Candidate` state if not part of stable configuration * add some comments to the tests * do not return if not transitioning state * add wait loop to test * remove test related to removed node voting * check `inConfig` instead of `hasVote` * updating warn log message to be more accurate
mkeeler
pushed a commit
that referenced
this pull request
Nov 3, 2021
* modify `TestRaft_RemoveFollower` to check removed node state * add test to verify that a removed node is not able to vote * do not transition to `Candidate` state if not part of stable configuration * add some comments to the tests * do not return if not transitioning state * add wait loop to test * remove test related to removed node voting * check `inConfig` instead of `hasVote` * updating warn log message to be more accurate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a follower is removed from the cluster it's removed from the configuration servers list but still run a follower loop (originally a follower node or
ShutdownOnRemoveset tofalsefor Leader). When that node timeout (because it's not receiving heartbeat from the other nodes in the cluster), it transition to a Candidate state and try to trigger an election. 2 possible cases:This uncover 2 issue:
Candidate state. This is fixed in this PRRequestVoteRequestonly have theServerAddresswhich do not represent a unique ID of the node, the one stored in the configuration server list. A test that reproduce the issue is in node not part of the cluster is not allowed to vote #477