Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to example code #428

Merged
merged 1 commit into from Apr 12, 2021
Merged

Conversation

Jille
Copy link
Contributor

@Jille Jille commented Sep 11, 2020

Requested in #394

@stale
Copy link

stale bot commented Nov 11, 2020

Hey there,
We wanted to check in on this request since it has been inactive for at least 90 days.
Have you reviewed the latest godocs?
If you think this is still an important issue in the latest version of the Raft library or
its documentation please feel let us know and we'll keep it open for investigation.
If there is still no activity on this request in 30 days, we will go ahead and close it.
Thank you!

@stale stale bot added the waiting-reply label Nov 11, 2020
@Jille
Copy link
Contributor Author

Jille commented Nov 11, 2020

bump

@stale stale bot removed the waiting-reply label Nov 11, 2020
@schristoff
Copy link
Contributor

Howdy @Jille,
Thank you so much for contributing. I would love to add some reference implementation to this library, but I believe it should live within the Raft library. Perhaps we could add an /examples folder at the top level directory and bring in your implementation.

Just to set your expectations, we would like the examples to be self contained without external dependencies. Your implementation looks promising, however we may ask for some changes to improve the readability and other aspects.

@Jille
Copy link
Contributor Author

Jille commented Jan 5, 2021

Hey @s-christoff. Makes sense.

I have since moved on to other projects so won't have much time to contribute anymore. I'm happy to send a PR copying in the code (and don't object to any changes being made to it).

I would like to have a full example using gRPC somewhere. I've found multiple people searching for that. If you don't want that to live inside this repository, maybe having an external link would still be useful?

@stale stale bot removed the waiting-reply label Jan 5, 2021
@schristoff
Copy link
Contributor

Howdy @Jille,
Thank you so much for your patience on this. After numerous internal discussion, it has been decided that the original approach (linking to an external repository) is, at this time, the best option. If it is alright with you, I'll approve this changes and we may make some minor changes to the README to have it fit our style.

@Jille
Copy link
Contributor Author

Jille commented Apr 12, 2021

Hey @s-christoff! Thanks for following up :) Sounds great, feel free to make any changes you want of course :)

@schristoff schristoff merged commit 62cc4fc into hashicorp:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants