Check for shutdown in inmemPipeline before sending RPCs #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a race inside between the shutdownCh and the consumerCh in the select statement of inmempipeLine.AppendEntries, which could otherwise forward an RPC request to the consumer even if the transport was closed with InmemTransport.Close(). See also hashicorp#275 for a sample program that reproduces the race if ran long enough. The same program doesn't fail anymore with this change applied.
freeekanayaka
force-pushed
the
fix-inmem-transport-close-race
branch
from
394728d
to
e290521
Compare
freeekanayaka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a race inside between the shutdownCh and the
consumerCh in the select statement of inmempipeLine.AppendEntries,
which could otherwise forward an RPC request to the consumer even if
the transport was closed with InmemTransport.Close().
See also #275 for a sample program that reproduces the race if ran
long enough. The same program doesn't fail anymore with this change
applied.