HCP: error handling & empty source image id #90
Conversation
| if img == nil { | ||
| return errors.New("no go on empty image") | ||
| } |
There was a problem hiding this comment.
I think this was added to avoid a panic in case FromMappedData failed and returned a nil image. In this case, I think that this should panic, since the error was not checked. Also, this error is kind of weird.
There was a problem hiding this comment.
(I'm also super open to suggestions!)
There was a problem hiding this comment.
The error is weird but panicking too. Maybe improving the error message is better 🤔 what do you think? Making it a friendly panic 😆
azr
force-pushed
the
azr/empty-source-image
branch
from
07ddb72
to
52e55e7
Compare
There was a problem hiding this comment.
In a 1:1 zoom with @nywilken, we are going to merge this one.
It is okay if SourceImageID is not set, and we can revisit that when we work on ancestry.
It's okay to panic when img is nil after an instantiation call failed.
No description provided.