ssh: add -d option to scp when copying directories #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -d option of scp, as for the -t option, is an undocumented one, and is used for specifying that we are working in directory mode. In effect, this flag ensures that the target is to be a directory, and implies that scp will check that the target directory exists before attempting to copy the contents of the source. Adding this flag to the scp sink makes the communicator behave correctly in relation to the scp command as it would be used by clients, rejecting copies to a non-existent destination directory, rather than mistakenly creating it, partially (or completely) copying the source's contents, and potentially succeeding where it should not.
As with the directory upload, not specifying the -d option in scp when uploading a file may result in uploading succeeding even when the destination directory (if suffixed by a `/') succeeds, and makes the resulting file upload take the name of the destination directory. To avoid this problem, we add the option so that if the destination is explicitely a directory, this does not succeed anymore.
nywilken
added
the
version/bump minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The -d option of scp, as for the -t option, is an undocumented one, and is used for specifying that we are working in directory mode.
In effect, this flag ensures that the target is to be a directory, and implies that scp will check that the target directory exists before attempting to copy the contents of the source.
Adding this flag to the scp sink makes the communicator behave correctly in relation to the scp command as it would be used by clients, rejecting copies to a non-existent destination directory, rather than mistakenly creating it, partially (or completely) copying the source's contents, and potentially succeeding where it should not.